-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final cleanup to move to publishing design-system-tokens to dist/ #70
Conversation
🦋 Changeset detectedLatest commit: fdf1d48 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). hds-flight-website – ./🔍 Inspect: https://vercel.com/hashicorp/hds-flight-website/9F4mDevvyXcQRodiRxjsRShowmSL hds-components – ./🔍 Inspect: https://vercel.com/hashicorp/hds-components/HFdqWoDjq8xyySz3AsiWrKjzcySY |
11198dd
to
77f6b0d
Compare
77f6b0d
to
fdf1d48
Compare
@Dhaulagiri shouldn't be a |
@didoo normally yes, but the package is pre 1.0 so it's a bit more nuanced (i think). If I indicated it as a "major" change it would release 1.0 of the package which we don't want to do here. |
OK, makes sense. |
📌 Summary
Building on #69, this fully moves to publishing design-system-tokens to
dist/
and updates documentation and references in our code.Note: this is a breaking change that will require consumers to update their paths
🛠️ Detailed description
After this PR is merged
This PR undoes a lot of the magic we put in place to get things working and should ultimately simplify things for us and for consumers.
✅ Reviewer's checklist
💬 Please consider using conventional comments when reviewing this PR.