Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final cleanup to move to publishing design-system-tokens to dist/ #70

Merged
merged 5 commits into from
Mar 16, 2022

Conversation

Dhaulagiri
Copy link
Collaborator

@Dhaulagiri Dhaulagiri commented Mar 15, 2022

📌 Summary

Building on #69, this fully moves to publishing design-system-tokens to dist/ and updates documentation and references in our code.

Note: this is a breaking change that will require consumers to update their paths

🛠️ Detailed description

After this PR is merged

~/c/w/d/p/tokens (br-tokens-post-dist|✚10) $ npm publish --dry-run
npm notice 
npm notice 📦  @hashicorp/design-system-tokens@0.5.1
npm notice === Tarball Contents === 
npm notice 16.7kB  LICENSE.md                              
npm notice 1.4kB   README.md                               
npm notice 3.7kB   dist/devdot/css/helpers/color.css       
npm notice 1.1kB   dist/devdot/css/helpers/elevation.css   
npm notice 158B    dist/devdot/css/helpers/focus-ring.css  
npm notice 2.6kB   dist/devdot/css/helpers/typography.css  
npm notice 21.0kB  dist/devdot/css/tokens.css              
npm notice 133.1kB dist/docs/devdot/tokens.json            
npm notice 132.3kB dist/docs/products/tokens.json          
npm notice 3.6kB   dist/products/css/helpers/color.css     
npm notice 1.1kB   dist/products/css/helpers/elevation.css 
npm notice 158B    dist/products/css/helpers/focus-ring.css
npm notice 2.6kB   dist/products/css/helpers/typography.css
npm notice 20.8kB  dist/products/css/tokens.css            
npm notice 1.1kB   package.json                            
npm notice === Tarball Details === 
npm notice name:          @hashicorp/design-system-tokens          
npm notice version:       0.5.1                                    
npm notice filename:      @hashicorp/design-system-tokens-0.5.1.tgz
npm notice package size:  25.9 kB                                  
npm notice unpacked size: 341.3 kB                                 
npm notice shasum:        3dd800e97db43bb51859ef0795ae458c57373923 
npm notice integrity:     sha512-OcgCSKjfH6nTG[...]MsvJh9cVDmwCg== 
npm notice total files:   15                                       
npm notice 

This PR undoes a lot of the magic we put in place to get things working and should ultimately simplify things for us and for consumers.


✅ Reviewer's checklist

  • +1 Percy if applicable
  • Confirm that PR has a changelog update via Changesets if needed

💬 Please consider using conventional comments when reviewing this PR.

@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2022

🦋 Changeset detected

Latest commit: fdf1d48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hashicorp/design-system-tokens Minor
@hashicorp/design-system-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 15, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

hds-flight-website – ./

🔍 Inspect: https://vercel.com/hashicorp/hds-flight-website/9F4mDevvyXcQRodiRxjsRShowmSL
✅ Preview: https://hds-flight-website-git-br-tokens-post-dist-hashicorp.vercel.app

hds-components – ./

🔍 Inspect: https://vercel.com/hashicorp/hds-components/HFdqWoDjq8xyySz3AsiWrKjzcySY
✅ Preview: https://hds-components-git-br-tokens-post-dist-hashicorp.vercel.app

@Dhaulagiri Dhaulagiri marked this pull request as draft March 15, 2022 18:25
@Dhaulagiri Dhaulagiri force-pushed the br-tokens-post-dist branch from 11198dd to 77f6b0d Compare March 15, 2022 21:01
@vercel vercel bot temporarily deployed to Preview – hds-flight-website March 15, 2022 21:01 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components March 15, 2022 21:01 Inactive
@Dhaulagiri Dhaulagiri force-pushed the br-tokens-post-dist branch from 77f6b0d to fdf1d48 Compare March 16, 2022 11:56
@vercel vercel bot temporarily deployed to Preview – hds-flight-website March 16, 2022 11:56 Inactive
@vercel vercel bot temporarily deployed to Preview – hds-components March 16, 2022 11:56 Inactive
@Dhaulagiri Dhaulagiri marked this pull request as ready for review March 16, 2022 12:06
@Dhaulagiri Dhaulagiri requested review from didoo and amyrlam March 16, 2022 12:55
@didoo
Copy link
Contributor

didoo commented Mar 16, 2022

@Dhaulagiri shouldn't be a major bump this one?
screenshot_1101
screenshot_1102

@Dhaulagiri
Copy link
Collaborator Author

@didoo normally yes, but the package is pre 1.0 so it's a bit more nuanced (i think). If I indicated it as a "major" change it would release 1.0 of the package which we don't want to do here.

@didoo
Copy link
Contributor

didoo commented Mar 16, 2022

@didoo normally yes, but the package is pre 1.0 so it's a bit more nuanced (i think). If I indicated it as a "major" change it would release 1.0 of the package which we don't want to do here.

OK, makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants