"Button" component - Fix "elevation" treatment #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c08711e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). hds-flight-website – ./🔍 Inspect: https://vercel.com/hashicorp/hds-flight-website/Hidt7ejw4xXoD8oAPwgx2cbXW29D hds-components – ./🔍 Inspect: https://vercel.com/hashicorp/hds-components/tfDUhQ2orUZjdkp3HiCNUGknh3px |
heatherlarsen
approved these changes
Mar 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
While working on #76 I noticed that the way we applied the "elevation" styles to the `Button" component was not in sync with the design specs in Figma.
In this PR I have update the code accordingly to the designs.
Preview of the documentation page: https://hds-components-git-fix-button-elevation-treatment-hashicorp.vercel.app/components/button
📸 Screenshots
These are the Button's
colorandstatevariant that have aelevation-lowstyle applied (I've emphasized the effect to make it more visible)👀 How to review
👉 Review by files changed
Reviewer's checklist:
💬 Please consider using conventional comments when reviewing this PR.