Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow . in Environment Variable Names #2

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Allow . in Environment Variable Names #2

merged 1 commit into from
Jan 19, 2018

Commits on Jan 19, 2018

  1. Allow . in Environment Variable Names 

    From https://github.com/appc/spec/blob/master/spec/aci.md:

> environment (list of objects, optional) represents the app's environment variables (ACE can append). The listed objects must have two key-value pairs: name and value. The name must consist solely of letters, digits, and underscores '_' as outlined in IEEE Std 1003.1-2008, 2016 Edition, with practical considerations dictating that the name may also include periods '.' and hyphens '-'. The value is an arbitrary string. These values are not evaluated in any way, and no substitutions are made.

Dotted environment variables are frequently used as a part of the Spring Boot pattern. (re: ZD-6116)

See also [Nomad PR# 3760](hashicorp/nomad#3760)
    @angrycub
    angrycub committed Jan 19, 2018
    Configuration menu
    Copy the full SHA
    1ba1b73 View commit details
    Browse the repository at this point in the history