Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not append timestamp to current log file #62

Closed
wants to merge 2 commits into from
Closed

do not append timestamp to current log file #62

wants to merge 2 commits into from

Commits on Aug 31, 2021

  1. do not append timestamp to current log file 

    This patch updates the file_sink to *not* append the timestamp on the
current log file. The timestamp is only appended when the file is
rotated.

This matches the behavior:

- Implemented in Nomad v1.1.4 with hashicorp/nomad#11070
- Requested in hashicorp/nomad#11061
- Referenced in Consul's documentation:
  https://www.consul.io/docs/enterprise/audit-logging

> The following example configures a destination called "My Sink" which
> stores audit events at the file `/tmp/audit.json`.

Nomad's documentation is a little vague but implies the prior behavior
of always appending a timestamp.

While this is a *backward incompatible change* I think it's worth it for
usability and matching Consul's documentation. Nomad's documentation can
be fixed and a notice placed in the Upgrade Guide.
    @schmichael
    schmichael committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    c3f114d View commit details
    Browse the repository at this point in the history

  2. bump Go version to 1.16 

    Fixes tests that now use os.ReadDir as well as matches go.mod
    @schmichael
    schmichael committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    ce4a38c View commit details
    Browse the repository at this point in the history