Support for custom headers #71
Comments
|
@codekoala the docs say you can pass the private token via a query parameter as well. It's not secure but it should work. Not sure how much would have to change for go-getter and nomad to support custom headers |
|
@lfarnell thank you for the response! It's been a while since I worked on this (ended up pushing artifacts to S3), but I'm fairly certain I tried that query string parameter without results. I think it worked for certain part of the API, but the artifacts seemed to be an exception for everything other than the header. I will try the query parameter later tonight and report back. That would be great if it works! One way or another, being able to specify custom headers seems like a good feature to deal with less flexible APIs. |
This adds the ability to set headers that will be sent out on every request of a particular HttpGetter. This is useful in situations where query parameters are not suitable, such as when headers are explicitly expected, or when one wants to move information off the query string that would be at risk of possibly being exposed in logs or error messages. Fixes #71.
|
I don't think the issue was addressed, the PR doesn't allow to pass headers using Nomad's artifact stanza. |
I want to download build artifacts from a private GitLab instance using Nomad's artifact stanza. I can download the build artifacts with curl if I add a
Private-Tokenheader, but there doesn't seem to be a way to handle withgo-getterright now.The text was updated successfully, but these errors were encountered: