getfile on windows: when a file cannot be symlinked for privilege reasons, copy it #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…no privilege, copy it Symlinking allows to optimize the space taken by go-get in case the operation runs locally. But running the go getter without the symlinking privilege can fail in this case. This will copy the file instead of symlinking it in case we don't have the priviledge.
|
Another fix for this would be to have the go-getter do nothing and find a way to tell the caller that the file is local so that the caller can use it in place. Like a |
|
This feels totally fine? I'd be fine changing the documentation for |
|
I have the same feeling you have, it feels fine. Here we go about the doc update 🙂. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symlinking allows to optimize the space taken by go-get in case the operation runs locally.
But running the go getter without the symlinking privilege can fail in this case.
This will copy the file instead of symlinking it in case we don't have the priviledge, so that the go-get doesn't fail.
closes #39
related: hashicorp/nomad#3491
This could also be an option passed to the client ? That we could turn on/off.