Adds support for Symlinks in all Tar decompressors #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful when using Nomad's Artefact mechanisms which internally uses `hashicorp/go-getter` to unpack Tar archives that are built from container root file systems (*which usually contain symlinks for runtime libraries*). Fixes #60 and supercedes the very old PR #37 (We use a variant of this patch in our production systems and we need to get this into upstream as soon as conveniently possible)
|
|
|
NB: I deliberately did not add Hard link support here as we don't really need it for our use-case and that can come later as a separate PR. |
johnzhanghua
reviewed
Mar 9, 2019
|
🏓 |
azr
approved these changes
Mar 12, 2019
Thanks for the review and approval! Yeah we don't really need hardlinks anyway as I know of no root file-system tooling that generate hardlinks instead of symlinks for system/application libraries ( Who shall merge this? |
nvm :) Thanks! |
This was referenced Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful when using Nomad's Artefact mechanisms which internally
uses
hashicorp/go-getterto unpack Tar archives that are built fromcontainer root file systems (which usually contain symlinks for runtime
libraries).
Fixes #60 and supercedes the very old PR #37
(We use a variant of this patch in our production systems and we need to
get this into upstream as soon as conveniently possible)