Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for vhost-style s3 buckets #283

Merged
merged 1 commit into from
Nov 12, 2020
Merged

Adds support for vhost-style s3 buckets #283

merged 1 commit into from
Nov 12, 2020

Conversation

danieleva
Copy link
Contributor

I have the feeling there is a more elegant way to do this avoiding the code repetition, but it works.
Closes #263

@mdeggies mdeggies changed the base branch from master to main October 23, 2020 00:53
This was referenced Nov 12, 2020
Closed
Closed
picatz
picatz approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@picatz picatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@picatz
Copy link
Contributor

picatz commented Nov 12, 2020

@azr I believe this change will also need to go into v2 for Packer? 🤔

@picatz picatz merged commit b277a4e into hashicorp:main Nov 12, 2020
@picatz
Copy link
Contributor

picatz commented Nov 12, 2020 •
edited

Fix available in v1.5.1

@danieleva danieleva deleted the s3_vhost branch November 13, 2020 09:17
@picatz picatz mentioned this pull request Nov 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picatz picatz picatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for newer dot region AWS S3 virtual host style paths
2 participants
@danieleva @picatz