Improve s3 format examples in README #394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This specifies what formats work with s3 and which do not. Specifically the s3 URL prefixed with http:// or https:// mentioned in the official AWS docs does NOT work
ghost
mentioned this pull request
This was referenced Nov 7, 2022
Merged
Merged
Merged
Merged
Merged
ghost
mentioned this pull request
ghost
closed this by deleting the head repository
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #387
This specifies what formats work with s3 and which do not. Specifically the s3 URL prefixed with http:// or https:// mentioned in the official AWS docs does NOT work (this is a known limitation as of 2016)
I've tested all of the formats in this PR with a go-getter binary, which is how I found that the
s3://prefix works.