Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport fix from https://github.com/hashicorp/go-getter/pull/497 to v2 #498

Merged
merged 2 commits into from
Jul 23, 2024

Commits on Jun 28, 2024

  1. Recreate git config during update to prevent git config alteration

    Backport fix from #497 to v2
    nywilken committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    b6203bd View commit details
    Browse the repository at this point in the history
  2. Bump version of Golang container to match module version

    The Go module for v2 is 1.19, bumping the base docker image to match the
    minimum version ensures go-getter can be compiled and executed on the
    container. This change resolves the failing acceptance test for Samba.
    
    ```
    Run docker exec -i gogetter bash -c "env ACC_SMB_TEST=1 go test -v ./... -run=TestSmb_"
      docker exec -i gogetter bash -c "env ACC_SMB_TEST=1 go test -v ./... -run=TestSmb_"
      shell: /usr/bin/bash -e {0}
      env:
        TEST_RESULTS_PATH: /tmp/test-results
    Error: ./get_git.go:366:16: undefined: os.ReadDir
    Error: ./get_git_test.go:886:9: undefined: os.WriteFile
    Error: ./get_git_test.go:904:22: undefined: os.ReadFile
    note: module requires Go 1.19
    FAIL	github.com/hashicorp/go-getter/v2 [build failed]
    ?   	github.com/hashicorp/go-getter/v2/helper/testing	[no test files]
    testing: warning: no tests to run
    PASS
    ok  	github.com/hashicorp/go-getter/v2/helper/url	0.006s [no tests to run]
    FAIL
    Error: Process completed with exit code 2.
    
    ```
    nywilken committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    e1b32e6 View commit details
    Browse the repository at this point in the history