-
Notifications
You must be signed in to change notification settings - Fork 24
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
disable test that won't work without a hosts entry
- Loading branch information
Showing
2 changed files
with
185 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,165 @@ | ||
| package httputil | ||
|
|
||
| import ( | ||
| "crypto/ecdsa" | ||
| "crypto/elliptic" | ||
| "crypto/rand" | ||
| "crypto/tls" | ||
| "crypto/x509" | ||
| "crypto/x509/pkix" | ||
| "encoding/asn1" | ||
| "github.com/hashicorp/go-hclog" | ||
| "math/big" | ||
| "net" | ||
| "net/http" | ||
| "net/http/httptest" | ||
| "strings" | ||
| "testing" | ||
| "time" | ||
| ) | ||
|
|
||
| var ( | ||
| inhibitAnyPolicyExt = asn1.ObjectIdentifier{2, 5, 29, 54} | ||
| policyConstraintExt = asn1.ObjectIdentifier{2, 5, 29, 36} | ||
| ) | ||
|
|
||
| func TestClient(t *testing.T) { | ||
| srvWith := newTLSServer(t, true, "localhost") | ||
| defer srvWith.Close() | ||
| // Only works with a host entry | ||
| //srvWithout := newTLSServer(t, false, "example.com") | ||
| //defer srvWithout.Close() | ||
|
|
||
| tests := []struct { | ||
| name string | ||
| extsToIgnore []asn1.ObjectIdentifier | ||
| errContains string | ||
| srv *httptest.Server | ||
| }{ | ||
| { | ||
| name: "no-overrides", | ||
| errContains: "x509: unhandled critical extension", | ||
| srv: srvWith, | ||
| }, | ||
| { | ||
| name: "partial-override", | ||
| extsToIgnore: []asn1.ObjectIdentifier{inhibitAnyPolicyExt}, | ||
| errContains: "x509: unhandled critical extension", | ||
| srv: srvWith, | ||
| }, | ||
| { | ||
| name: "full-override", | ||
| extsToIgnore: []asn1.ObjectIdentifier{inhibitAnyPolicyExt, policyConstraintExt}, | ||
| srv: srvWith, | ||
| }, | ||
| /*{ | ||
| name: "other-name", | ||
| extsToIgnore: []asn1.ObjectIdentifier{inhibitAnyPolicyExt, policyConstraintExt}, | ||
| srv: srvWithout, | ||
| },*/ | ||
| } | ||
|
|
||
| for _, tc := range tests { | ||
| tc := tc | ||
| t.Run(tc.name, func(t *testing.T) { | ||
| client := getClient(t, tc.srv, tc.extsToIgnore) | ||
| resp, err := client.Get(tc.srv.URL) | ||
| if len(tc.errContains) > 0 { | ||
| if err == nil { | ||
| t.Fatal("expected error, got nil") | ||
| } | ||
| if !strings.Contains(err.Error(), tc.errContains) { | ||
| t.Fatalf("expected error to contain '%s', got '%s'", tc.errContains, err.Error()) | ||
| } | ||
| } else { | ||
| if err != nil { | ||
| t.Fatalf("unexpected error: %s", err) | ||
| } | ||
|
|
||
| defer func() { _ = resp.Body.Close() }() | ||
| if resp.StatusCode != http.StatusOK { | ||
| t.Fatalf("got status code: %v", resp.StatusCode) | ||
| } | ||
| } | ||
| }) | ||
| } | ||
| } | ||
|
|
||
| func getClient(t *testing.T, srv *httptest.Server, extsToIgnore []asn1.ObjectIdentifier) *http.Client { | ||
| srvCertsRaw := srv.TLS.Certificates[0] | ||
| rootCert, err := x509.ParseCertificate(srvCertsRaw.Certificate[0]) | ||
| if err != nil { | ||
| t.Fatalf("failed parsing root ca certificate: %v", err) | ||
| } | ||
|
|
||
| certpool := x509.NewCertPool() | ||
| certpool.AddCert(rootCert) | ||
| client := http.Client{ | ||
| Transport: NewIgnoreUnsupportedExtensionsRoundTripper(hclog.New(hclog.DefaultOptions), &http.Transport{ | ||
| TLSClientConfig: &tls.Config{ | ||
| RootCAs: certpool, | ||
| }, | ||
| }, extsToIgnore), | ||
| } | ||
| return &client | ||
| } | ||
|
|
||
| func newTLSServer(t *testing.T, withUnsupportedExts bool, hostname string) *httptest.Server { | ||
| ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) { | ||
| defer func() { _ = req.Body.Close() }() | ||
| w.WriteHeader(http.StatusOK) | ||
| _, _ = w.Write([]byte("Hello World!")) | ||
| })) | ||
|
|
||
| ts.TLS = &tls.Config{Certificates: []tls.Certificate{getSelfSignedRoot(t, withUnsupportedExts)}} | ||
| ts.StartTLS() | ||
| ts.URL = strings.Replace(ts.URL, "127.0.0.1", hostname, 1) | ||
| return ts | ||
| } | ||
|
|
||
| func getSelfSignedRoot(t *testing.T, withUnsupportedExts bool) tls.Certificate { | ||
| key, err := ecdsa.GenerateKey(elliptic.P256(), rand.Reader) | ||
| if err != nil { | ||
| t.Fatalf("failed to generate private key: %v", err) | ||
| } | ||
| pub := key.Public() | ||
|
|
||
| inhibitExt := pkix.Extension{ | ||
| Id: inhibitAnyPolicyExt, | ||
| Critical: true, | ||
| Value: []byte{2, 1, 0}, | ||
| } | ||
|
|
||
| polConstraint := pkix.Extension{ | ||
| Id: policyConstraintExt, | ||
| Critical: true, | ||
| Value: []byte{48, 6, 128, 1, 0, 129, 1, 0}, | ||
| } | ||
|
|
||
| caTemplate := &x509.Certificate{ | ||
| Subject: pkix.Name{CommonName: "Root CA with bad extensions"}, | ||
| SerialNumber: big.NewInt(1), | ||
| NotBefore: time.Now().Add(-5 * time.Minute), | ||
| NotAfter: time.Now().Add(10 * time.Minute), | ||
| KeyUsage: x509.KeyUsageCertSign | x509.KeyUsageDigitalSignature | x509.KeyUsageCRLSign, | ||
| ExtKeyUsage: []x509.ExtKeyUsage{x509.ExtKeyUsageAny}, | ||
| IPAddresses: []net.IP{net.IPv4(127, 0, 0, 1)}, | ||
| } | ||
| if withUnsupportedExts { | ||
| caTemplate.ExtraExtensions = []pkix.Extension{polConstraint, inhibitExt} | ||
| caTemplate.DNSNames = []string{"localhost"} | ||
| } else { | ||
| caTemplate.DNSNames = []string{"example.com"} | ||
|
|
||
| } | ||
|
|
||
| caBytes, err := x509.CreateCertificate(rand.Reader, caTemplate, caTemplate, pub, key) | ||
| if err != nil { | ||
| t.Fatalf("failed to marshal CA certificate: %v", err) | ||
| } | ||
|
|
||
| return tls.Certificate{ | ||
| Certificate: [][]byte{caBytes}, | ||
| PrivateKey: key, | ||
| } | ||
| } |