Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugincontainer: use docker v27 #136

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

tvoran
Copy link
Member

@tvoran tvoran commented Sep 11, 2024

Replace types.ImageListOptions with image.ListOptions, update docker and otlptracehttp to latest.

go get github.com/docker/docker@latest
go get go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp@latest
go mod tidy

Fixes #135

go get github.com/docker/docker@latest
go get go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp@latest
go mod tidy
Copy link

@AndyYan007 AndyYan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@tvoran tvoran requested review from a team and sgmiller September 11, 2024 19:19
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AndyYan007
Copy link

Do we have an ETA when this change can be merged and released? Confluent has some services with dependency on this change.

@AndrewYinLi
Copy link

@sgmiller Any ETA on this?

@AndrewYinLi
Copy link

@tvoran Is it possible to merge with just one review?

@lursu lursu merged commit be09a04 into main Sep 19, 2024
22 checks passed
@tvoran tvoran deleted the plugincontainer/VAULT-30850/use-docker-v27 branch September 19, 2024 19:41
@tvoran
Copy link
Member Author

tvoran commented Sep 19, 2024

Tagged plugincontainer/v0.4.1

dmitryax added a commit to signalfx/splunk-otel-collector that referenced this pull request Oct 25, 2024
hashicorp/go-secure-stdlib#136 is resolved and released as part of v0.4.1. No need to block docker dependancies fron the upgrade anymore
dmitryax added a commit to signalfx/splunk-otel-collector that referenced this pull request Oct 25, 2024
hashicorp/go-secure-stdlib#136 is resolved and released as part of v0.4.1. No need to block docker dependancies fron the upgrade anymore
dmitryax added a commit to signalfx/splunk-otel-collector that referenced this pull request Oct 25, 2024
hashicorp/go-secure-stdlib#136 is resolved and released as part of v0.4.1. No need to block docker dependancies fron the upgrade anymore
dmitryax added a commit to signalfx/splunk-otel-collector that referenced this pull request Oct 25, 2024
hashicorp/go-secure-stdlib#136 is resolved and released as part of v0.4.1. No need to block docker dependancies fron the upgrade anymore
dmitryax added a commit to signalfx/splunk-otel-collector that referenced this pull request Oct 25, 2024
hashicorp/go-secure-stdlib#136 is resolved and released as part of v0.4.1. No need to block docker dependancies fron the upgrade anymore
dmitryax added a commit to signalfx/splunk-otel-collector that referenced this pull request Oct 25, 2024
hashicorp/go-secure-stdlib#136 is resolved and released as part of v0.4.1. No need to block docker dependancies fron the upgrade anymore
dmitryax added a commit to signalfx/splunk-otel-collector that referenced this pull request Oct 25, 2024
hashicorp/go-secure-stdlib#136 is resolved and released as part of v0.4.1. No need to block docker dependancies fron the upgrade anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading the docker/docker package to v27.2.0
5 participants