sourcebundle: Fix panic when RegistryMeta and Packages aren't the same size #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Agreed this looks like a copy-paste error.
I guess it is not very surprising for something like this to be overlooked in 4,7k+ LOC of changes #42 🤷🏻
|
Closed in favour of #68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like a copy-paste error here. I think this works most of the time because packages and registrymeta are usually the same size. But, if someone loads a package directly from Github (or another source) without going through the registry this panics.