Support count and count.index completion in blocks #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpogran
force-pushed
the
expression_extensions
branch
from
34b8c93 to
f5f3f14
Compare
jpogran
force-pushed
the
expression_extensions
branch
5 times, most recently
from
ba4f9d6 to
aaf1fa8
Compare
jpogran
changed the title
jpogran
force-pushed
the
expression_extensions
branch
from
aaf1fa8 to
3406e0c
Compare
dbanck
reviewed
Sep 23, 2022
There was a problem hiding this comment.
Quick review from my side: LGTM so far, just minor suggestions.
I think we should copy the BodySchema extensions when merging dependent body schemas as well. To be sure to cover every edge-case.
Lines 75 to 77 in 3406e0c
mergedSchema.Extensions = depSchema.Extensions.Copy()
575c954 to
2b2b977
Compare
This provides completion hints inside blocks for `count.index` references within resource, data and module blocks anywhere the `count` meta-argument is supported. It detects if count is used already and does not suggest duplicates.
jpogran
force-pushed
the
expression_extensions
branch
from
f0987e8 to
998e3b9
Compare
radeksimko
reviewed
Oct 10, 2022
Co-authored-by: Radek Simko <radek.simko@gmail.com>
Co-authored-by: Radek Simko <radek.simko@gmail.com>
Co-authored-by: Radek Simko <radek.simko@gmail.com>
jpogran
force-pushed
the
expression_extensions
branch
from
af583b2 to
533e459
Compare
radeksimko
approved these changes
Oct 12, 2022
Co-authored-by: Radek Simko <radek.simko@gmail.com>
|
Feedback is added and test is added! |
This was referenced Oct 13, 2022
jpogran
added a commit
to hashicorp/terraform-ls
that referenced
this pull request
Oct 13, 2022
In hashicorp/hcl-lang#134 we now pass the context down to the decoder if using Hover or SemanticTokens.
jpogran
added a commit
to hashicorp/terraform-ls
that referenced
this pull request
Oct 18, 2022
In hashicorp/hcl-lang#134 we now pass the context down to the decoder if using Hover or SemanticTokens. Updated hcl-lang and terraform-schema references.
jpogran
added a commit
to hashicorp/terraform-ls
that referenced
this pull request
Oct 18, 2022
In hashicorp/hcl-lang#134 we now pass the context down to the decoder if using Hover or SemanticTokens. Updated hcl-lang and terraform-schema references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides completion hints inside blocks for
count.indexreferences within resource, data and module blocks anywhere thecountmeta-argument is supported. It detects if count is used already and does not suggest duplicates.Closes hashicorp/terraform-ls#860