Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support foreach and each.* schema extensions #142

Closed
wants to merge 8 commits into from
Closed

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Oct 19, 2022

No description provided.

@jpogran jpogran self-assigned this Oct 19, 2022
@jpogran jpogran changed the title foreach extensions Support foreach and each.* schema extensions Oct 19, 2022
@@ -533,7 +536,7 @@ func TestCompletionAtPos_BodySchema_Extensions(t *testing.T) {
},
},
NewText: "for_each",
Snippet: "for_each = ${1:1}",
Snippet: "for_each {\n ${1}\n}",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original snippet was correct - for_each is not a block, but an attribute, so there's no need for the curly braces and newlines.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was following the first example in https://www.terraform.io/language/meta-arguments/for_each#basic-syntax. I missed the quals sign, but thought since it shows map first that is the likely first choice to use

@jpogran
Copy link
Contributor Author

jpogran commented Oct 25, 2022

This had too many conflicts with #144, so I've closed this in favor of a fresh start in #145

@jpogran jpogran closed this Oct 25, 2022
@radeksimko radeksimko deleted the foreach_extensions branch January 16, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants