Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid completing static block inside a dynamic label #165

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Nov 25, 2022

This PR fixes an error where we're offering static blocks for completion when there are no blocks in the dependent body.

Before

Screenshot 2022-11-24 at 15 59 21

After

CleanShot 2022-11-29 at 17 39 00
dynamic isn't available anymore, because there are no blocks in the dependent body.

@dbanck dbanck added the bug Something isn't working label Nov 25, 2022
@dbanck dbanck self-assigned this Nov 25, 2022
@dbanck dbanck force-pushed the b-static-blocks-in-label branch from 3756338 to ed6bd92 Compare November 29, 2022 16:29
@dbanck dbanck requested a review from a team November 29, 2022 16:40
@dbanck dbanck marked this pull request as ready for review November 29, 2022 16:40
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor suggestion.

decoder/decoder.go Outdated Show resolved Hide resolved
@dbanck dbanck merged commit e6f0252 into main Nov 30, 2022
@dbanck dbanck deleted the b-static-blocks-in-label branch November 30, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants