Add support for ObjectExpr expression type #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-object-expr
branch
4 times, most recently
from
4315086 to
df95a1d
Compare
radeksimko
commented
Mar 10, 2021
| @@ -30,15 +30,17 @@ func detailForAttribute(attr *schema.AttributeSchema) string { | |||
| var detail string | |||
| if attr.IsRequired { | |||
| detail = "Required" | |||
| } else { | |||
| } else if attr.IsOptional { | |||
There was a problem hiding this comment.
This was actually never correct, it just came up now because AnyAttribute (where none of Required or Optional is typically set) is used in the required_providers block which was changed in 0.15.
radeksimko
commented
Mar 10, 2021
| Kind: lang.TupleCandidateKind, | ||
| Label: fmt.Sprintf(`[%s]`, labelForConstraints(c.AnyElem)), | ||
| Detail: c.Name, | ||
| Description: c.Description, |
There was a problem hiding this comment.
Small (unrelated) fix I made as I was reading through the code, probably doesn't affect much in practice though as we don't have too many tuple expressions with description.
radeksimko
commented
Mar 10, 2021
| Kind: lang.MapCandidateKind, | ||
| Label: fmt.Sprintf(`{ key =%s}`, labelForConstraints(c.Elem)), | ||
| Detail: c.FriendlyName(), | ||
| Description: c.Description, |
There was a problem hiding this comment.
Small (unrelated) fix I made as I was reading through the code, probably doesn't affect much in practice though as we don't have too many map expressions with description.
radeksimko
force-pushed
the
f-object-expr
branch
from
df95a1d to
61ccc17
Compare
13 tasks
aeschright
approved these changes
Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support recent changes in core schema introduced in Terraform 0.15 where an object can contain traversals - i.e. not literals.