Fix attribute lookup for dependent schemas #25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a conversion function which was previously not covered by tests.
This bug in combination with another bug hashicorp/terraform-schema#28 caused the dependent schemas of
resource
ordata
block to be looked up basically freely without theprovider
attribute being considered.In other words most of the time it looked like everything is working fine, but there were some configurations being misinterpreted, e.g.
It is true that providers of
hashicorp
(default) namespace do not require explicitrequired_providers
entry, however if they do have one, it should be respected.Here due to the combination of the two bugs we would look up
hashicorp/random
schema forrandom_string
resource block, but that provider really isn't supposed to be available under that name. It requires explicit association.