-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
decoder: Add support for parenthesis on LHS (map keys & attribute names) #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-expr-parenthesis-lhs
branch
from
January 18, 2024 20:37
3eeec7e
to
e53cd53
Compare
radeksimko
force-pushed
the
f-expr-parenthesis-lhs
branch
from
January 19, 2024 10:05
e53cd53
to
c073161
Compare
dbanck
reviewed
Jan 19, 2024
dbanck
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just two small nits
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
This enables support for interpolated map keys and object attribute names,. Since this is enabled by parenthesis it is closely related to that linked PR which adds support for that expression type.
In other words this enables parenthesis support on the LHS (left hand side).
Example:
Implementation Notes
This does not enable equivalent support inside of inferred maps/objects, such as in the context of Terraform's
locals
. This is currently tracked under hashicorp/terraform-ls#1586It originally started out as "hidden implementation detail" of
decoder
(the decision whether interpolation is allowed was originally just implied byAnyExpression{}
until I realised that we still useschema.Map{}
andschema.Object{}
in contexts where we expect interpolation, including interpolated keys, so I had to walk it back and make it a more 1st class feature of the schema, for better or worse.For that reason, this will also require some changes downstream:
UX Examples
Completion
Hover
Semantic Tokens
Reference Origins