Add IsSensitive to AttributeSchema

[beandrad]

So that sensitive attributes can be flagged.

[radeksimko]

Thanks for the PR!

We'll need to reflect this new field also in hover data:

hcl-lang/decoder/attribute_candidates.go

Line 30 in b62f3a9

func detailForAttribute(attr *schema.AttributeSchema) string {

Also would you mind adding some test cases for the public CandidatesAtPos here

hcl-lang/decoder/candidates_test.go

Lines 803 to 807 in b62f3a9

	testCases := []struct {
	name string
	pos hcl.Pos
	expectedCandidates lang.Candidates
	}{

and similar for HoverAtPos here

hcl-lang/decoder/hover_test.go

Lines 328 to 332 in b62f3a9

	testCases := []struct {
	name string
	pos hcl.Pos
	expectedData *lang.HoverData
	}{

One case in each (with sensitive attribute) should suffice; if you want to be thorough you could add one with AttributeSchema where Expr is ObjectExpr with sensitive attribute nested within, although I'm not sure what's the current handling of it as nested expressions aren't well supported yet - but it's still nice to have a test that reflects the current behaviour - and will fail (and be fixed) as part of implementing hashicorp/terraform-ls#496

[radeksimko]

As per conversation in hashicorp/terraform-schema#49 (comment) we should also add some tests which test AttributeSchema with no explicit required/optional during completion or hover. I think the validation should keep reporting it as failure/error, but we can treat it as "soft enforcement" for pragmatic reasons, so the decoder should account for this edge case and test for it.

[radeksimko]

This is a reasonable change, but just FYI there will be some existing test data in the need of update potentially in terraform-schema and in terraform-ls 😅

[beandrad]

sounds exciting 🙈