Add type declarations for variable type
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beandrad
force-pushed
the
ia.type-declaration
branch
from
09c4e3d to
47260b2
Compare
radeksimko
reviewed
Jun 7, 2021
There was a problem hiding this comment.
This is a good start.
Aside from my in-line comments, I think this new expression type will also need to be reflected in SemanticTokensInFile so that we can highlight the types semantically. Relatedly we'll also need to introduce new token types for this purpose, as mentioned in hashicorp/terraform-ls#490
hcl-lang/decoder/semantic_tokens.go
Line 129 in f2d6b65
beandrad
force-pushed
the
ia.type-declaration
branch
2 times, most recently
from
c4706f8 to
5623ecf
Compare
radeksimko
reviewed
Jun 9, 2021
So that completion, hover and semantic-tokens work for variable `type`. Related to hashicorp/terraform-ls#490
beandrad
force-pushed
the
ia.type-declaration
branch
from
5623ecf to
d2a9b30
Compare
radeksimko
approved these changes
Jun 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that completion, hover and semantic-tokens work for variable
type.Related to hashicorp/terraform-ls#490