Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HCL JSON files #88

Merged
merged 8 commits into from
Oct 14, 2021
Merged

Add support for HCL JSON files #88

merged 8 commits into from
Oct 14, 2021

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Sep 21, 2021

The diff is unfortunately pretty big, but the majority of LOC is tests and some refactoring of tests.

The PR is probably best reviewed commit-by-commit.

@radeksimko radeksimko added the enhancement New feature or request label Sep 21, 2021
@radeksimko radeksimko marked this pull request as draft September 21, 2021 14:06
@radeksimko radeksimko force-pushed the f-hcl-json-support branch 2 times, most recently from 7befa32 to 8aa08f7 Compare September 28, 2021 14:29
@radeksimko radeksimko force-pushed the f-hcl-json-support branch 6 times, most recently from 3c0d262 to f551667 Compare October 12, 2021 11:56
@radeksimko radeksimko marked this pull request as ready for review October 14, 2021 12:20
@radeksimko radeksimko requested a review from a team October 14, 2021 12:38
@radeksimko radeksimko self-assigned this Oct 14, 2021
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome set of tests and thank you for all the comments, they helped alot!

@radeksimko radeksimko merged commit 0bfbdcc into main Oct 14, 2021
@radeksimko radeksimko deleted the f-hcl-json-support branch October 14, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants