-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HCL JSON files #88
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-hcl-json-support
branch
2 times, most recently
from
September 28, 2021 14:29
7befa32
to
8aa08f7
Compare
radeksimko
force-pushed
the
f-hcl-json-support
branch
from
October 8, 2021 14:36
8aa08f7
to
46e665e
Compare
radeksimko
force-pushed
the
f-hcl-json-support
branch
6 times, most recently
from
October 12, 2021 11:56
3c0d262
to
f551667
Compare
radeksimko
force-pushed
the
f-hcl-json-support
branch
from
October 13, 2021 14:00
f551667
to
752dd4d
Compare
radeksimko
force-pushed
the
f-hcl-json-support
branch
from
October 14, 2021 10:41
752dd4d
to
5856951
Compare
radeksimko
force-pushed
the
f-hcl-json-support
branch
from
October 14, 2021 12:17
5856951
to
372e16a
Compare
jpogran
approved these changes
Oct 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome set of tests and thank you for all the comments, they helped alot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff is unfortunately pretty big, but the majority of LOC is tests and some refactoring of tests.
The PR is probably best reviewed commit-by-commit.