This repository has been archived by the owner on Oct 3, 2019. It is now read-only.
return array value evaluation diagnostics #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug where diagnostics found when evaluating array individual elements are ignored, resulting in suppressed errors. Nomad observed this issue in hashicorp/nomad#5694.
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 68.69% 68.75% +0.05%
==========================================
Files 98 98
Lines 10299 10301 +2
==========================================
+ Hits 7075 7082 +7
+ Misses 2897 2894 -3
+ Partials 327 325 -2
Continue to review full report at Codecov.
|
notnoop
pushed a commit
to hashicorp/nomad
that referenced
this pull request
Jun 17, 2019
This upgrades hcl2 library dependency to pick up hashicorp/hcl2#113 . Prior to this change, parsing and decoding array attributes containing invalid errors (e.g. references to unknown variables) are silently dropped, with `cty.Unknown` being assigned to the bad element. Rather than showing a type/meaningful error from hcl2, we get a very decrypted error message from msgpack layer trying to handle `cty.unknown`. This ensures that we propagate diagnostics correctly and report meaningful errors to users. Fixes #5694 Fixes #5680
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where diagnostics found when evaluating array individual
elements are ignored, resulting in suppressed errors.
Nomad observed this issue in hashicorp/nomad#5694.