fix error on picking latest vault releases

[sinisterstumble]

The version 1.2.6.1+ent is not valid semver in https://releases.hashicorp.com/vault/index.json.

[hashicorp-cla]

All committers have signed the CLA.

[dbanck]

Hi @markmartirosian! Thanks a lot for catching this bug and raising this PR!

I've created some test cases for getRelease in #58 to catch and prevent bugs like this in the future. Do you mind rebasing the latest changes from main and adding a test case for versions like 1.2.6.1+ent? Something like it('should filter invalid versions', .... I'm happy to assist you with this or add the changes to your branch so that we can get this merged.

[sinisterstumble]

@dbanck something like this? (;

[dbanck]

Thanks for updating the PR with the changes from main and providing a test case!

Can you explain what your motivation is behind extending your solution? I think the one-line filter was an elegant solution as a bug fix.

Do you mind removing the changes to package-lock.json? Unfortunately, this project still uses an older version of npm, so the lock file is still version 1. I'm planning to update this in a separate PR soon.

[sinisterstumble]

@dbanck both codepaths: 1. new Release and 2: matchVersion depend on a versions: Record<string, Release>, this changes ensure that it's the same object in both cases. It's a little defensive, but ultimately reduces complexity and possibility of another bug given that the matchVersion uses semver.maxSatisfying on the versions object.

I've copied package-lock.json from the main branch. It's still showing changes for some reason.

You should have write permissions to the fork repo.

[dbanck]

Thanks for the write access! I rebased from main & force pushed to get rid of the changes in package-lock.json.

Unifying the versions for both code paths makes sense! I've added a new type ResponseVersion for the JSON response, because we can't use Release here. And one more test case when passing an invalid version.

[dbanck]

Thanks again for reporting and fixing this bug! 👍