-
Notifications
You must be signed in to change notification settings - Fork 34
Support extraction of content on build with onContent
function
#26
Conversation
onContent
function
@jescalan - The same thing that had happened previously with cache / permissions on the CI container is happening here as well. Background:
I am happen to look into solutions here, just figured you had more context around the pipeline or perhaps know of a fix already |
02fb1d5
to
c82d075
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks super good, great work on this feature! All we still need here is a bit more cleanup, get that test narrowed down to just the minimum it needs to pass 😀
Other docs: {introData.title}, {advancedData.title} | ||
</p> | ||
{children} | ||
</> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this content is needed since its not being tested - let's narrow the fixture down to only the things being tested!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @jmfury ! 🍒
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big improvement with the cut down tests, this looks ready to go for me!
79e6985
to
cdc1e80
Compare
This PR adds an
onContent
option to enable content to be processed for any purpose