Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Support extraction of content on build with onContent function #26

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

jmfury
Copy link
Contributor

@jmfury jmfury commented Oct 14, 2019

This PR adds an onContent option to enable content to be processed for any purpose

@jmfury jmfury changed the title Support indexing of content for search purposes Support extraction of content on build with onContent function Oct 14, 2019
@jmfury jmfury marked this pull request as ready for review October 15, 2019 15:37
@jmfury
Copy link
Contributor Author

jmfury commented Oct 15, 2019

@jescalan - The same thing that had happened previously with cache / permissions on the CI container is happening here as well.

Background:

I am happen to look into solutions here, just figured you had more context around the pipeline or perhaps know of a fix already

@jmfury jmfury force-pushed the jm.content-search-index branch from 02fb1d5 to c82d075 Compare October 17, 2019 21:59
@jmfury jmfury requested review from pruett and jescalan October 17, 2019 22:29
README.md Show resolved Hide resolved
Copy link
Contributor

@jescalan jescalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks super good, great work on this feature! All we still need here is a bit more cleanup, get that test narrowed down to just the minimum it needs to pass 😀

Other docs: {introData.title}, {advancedData.title}
</p>
{children}
</>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this content is needed since its not being tested - let's narrow the fixture down to only the things being tested!

Copy link
Contributor Author

@jmfury jmfury Oct 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jescalan - I cut this down here: 79e6985 ✂️

__tests__/fixtures/on-content/next.config.js Show resolved Hide resolved
Copy link
Contributor

@pruett pruett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @jmfury ! 🍒

Copy link
Contributor

@jescalan jescalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big improvement with the cut down tests, this looks ready to go for me!

@jmfury jmfury force-pushed the jm.content-search-index branch from 79e6985 to cdc1e80 Compare October 21, 2019 18:08
@jmfury jmfury merged commit fa66f14 into master Oct 21, 2019
@jmfury jmfury deleted the jm.content-search-index branch October 21, 2019 18:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants