This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
Fix for next@9.4.0 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pruett
reviewed
May 15, 2020
pruett
reviewed
May 15, 2020
index.js
Outdated
Comment on lines
58
to
74
| config.module.rules = config.module.rules.map((rule) => { | ||
| if (rule.use) { | ||
| if (Array.isArray(rule.use)) { | ||
| // client babel config is different from server - this is client | ||
| if (rule.use[1] && rule.use[1].loader === 'next-babel-loader') { | ||
| if (!rule.use[1].options.plugins) rule.use[1].options.plugins = [] | ||
| rule.use[1].options.plugins.push( | ||
| babelPluginFrontmatter(options, pluginOptions) | ||
| ) | ||
| } | ||
| // and this is server | ||
| } else if (rule.use.loader === 'next-babel-loader') { | ||
| if (!rule.use.options.plugins) rule.use.options.plugins = [] | ||
| rule.use.options.plugins.push( | ||
| babelPluginFrontmatter(options, pluginOptions) | ||
| ) | ||
| } |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nextjs made a change to the way that babel plugins are added to the client side bundle, which caused this plugin to work for the server but not client bundles. This was a very weird error, but it should be worked out now.
Interestingly, this was a case that was not caught by our tests, which compare the server-rendered output and don't test with javascript active after hydration. It mat be worth adding a test where everything is evaluated after hydrating in the future, I have one in next-mdx-remote.
Closes #53