Don't panic.

hashicorp · Nov 3, 2023 · de94069 · de94069
1 parent 9fa5abd
commit de94069
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/sdk/helper/nomad/config.go b/sdk/helper/nomad/config.go
@@ -71,12 +71,10 @@ func ConfigFromNamespacedMap(cfg map[string]string) *api.Config {
 	if httpAuth, ok := cfg[configKeyNomadHTTPAuth]; ok {
 		c.HttpAuth = HTTPAuthFromString(httpAuth)
 	}
-
+	// We may ignore errors from ParseDuration() here as the provided argument
+	// has already passed general validation as part of being a DurationVar flag.
 	if blockQueryWaitTimeDuration, ok := cfg[configKeyNomadWaitTime]; ok {
-		blockQueryWaitTimeDuration, err := time.ParseDuration(blockQueryWaitTimeDuration)
-		if err != nil {
-			panic(err)
-		}
+		blockQueryWaitTimeDuration, _ := time.ParseDuration(blockQueryWaitTimeDuration)
 		c.WaitTime = blockQueryWaitTimeDuration
 	}