Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: use run exit code if an error is produced #129

Closed
jrasell opened this issue May 15, 2020 · 0 comments · Fixed by #130
Closed

cli: use run exit code if an error is produced #129

jrasell opened this issue May 15, 2020 · 0 comments · Fixed by #130
Assignees
@jrasell
Milestone
0.0.2

Comments

@jrasell
Copy link
Member

jrasell commented May 15, 2020

Currently the main func will use exit code 1 if any error occurs when calling Run(). It is possible however that the function call returns an error along with a 127 exit code. It might therefore be prudent to always use the returned exit code, rather than call os.Exit(1) in the case of an error.
@jrasell jrasell added this to the 0.0.2 milestone May 15, 2020
@jrasell jrasell self-assigned this May 15, 2020
@jrasell jrasell mentioned this issue May 15, 2020
Merged
jrasell added a commit that referenced this issue May 18, 2020
@jrasell
Merge pull request #130 from hashicorp/gh-129
97f140d 
cli: always use cli exit code when exiting main function.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrasell jrasell

Labels
None yet
Projects
None yet
Milestone
0.0.2
Development

Successfully merging a pull request may close this issue.

cli: always use cli exit code when exiting main function. hashicorp/nomad-autoscaler
1 participant
@jrasell