-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoscaler can't connect to UNIX domain socket. #955
Labels
Comments
tgross
added a commit
that referenced
this issue
Sep 5, 2024
For #944 we fixed the Nomad API package so that it no longer mutated the private `url` field if previously set, which allowed reusing an `api.Config` object between clients when a unix domain socket was in use. However, the autoscaler plugins for Nomad strategy and target don't use the `api.Config` object we parse directly and instead get a map of string->string derived from that config so it can be passed over the go-plugin interface. This mapping did not account for the `Address` field being mutated when unix domain sockets are in use, so the bug was not actually fixed. Update the mapping to use the safe `URL()` method on the config, rather than reading the `Address` field. Fixes: #955 Ref: hashicorp/nomad#23785
tgross
added a commit
that referenced
this issue
Sep 5, 2024
For #944 we fixed the Nomad API package so that it no longer mutated the private `url` field if previously set, which allowed reusing an `api.Config` object between clients when a unix domain socket was in use. However, the autoscaler plugins for Nomad strategy and target don't use the `api.Config` object we parse directly and instead get a map of string->string derived from that config so it can be passed over the go-plugin interface. This mapping did not account for the `Address` field being mutated when unix domain sockets are in use, so the bug was not actually fixed. Update the mapping to use the safe `URL()` method on the config, rather than reading the `Address` field. Fixes: #955 Ref: hashicorp/nomad#23785
I've got a fix for this in #966 |
tgross
added a commit
that referenced
this issue
Sep 5, 2024
For #944 we fixed the Nomad API package so that it no longer mutated the private `url` field if previously set, which allowed reusing an `api.Config` object between clients when a unix domain socket was in use. However, the autoscaler plugins for Nomad strategy and target don't use the `api.Config` object we parse directly and instead get a map of string->string derived from that config so it can be passed over the go-plugin interface. This mapping did not account for the `Address` field being mutated when unix domain sockets are in use, so the bug was not actually fixed. Update the mapping to use the safe `URL()` method on the config, rather than reading the `Address` field. Fixes: #955 Ref: hashicorp/nomad#23785
tgross
added a commit
that referenced
this issue
Sep 11, 2024
For #944 we fixed the Nomad API package so that it no longer mutated the private `url` field if previously set, which allowed reusing an `api.Config` object between clients when a unix domain socket was in use. However, the autoscaler plugins for Nomad strategy and target don't use the `api.Config` object we parse directly and instead get a map of string->string derived from that config so it can be passed over the go-plugin interface. This mapping did not account for the `Address` field being mutated when unix domain sockets are in use, so the bug was not actually fixed. Update the mapping to use the safe `URL()` method on the config, rather than reading the `Address` field. Fixes: #955 Ref: hashicorp/nomad#23785
I've merged #966 and that'll go out in the next version. I don't know when that's scheduled but I'll look into expediting it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Nomad server version: 1.8.3
Nomad client version: 1.8.3
Nomad autoscaler version: 0.4.5 (with custom plugin)
I've started experimenting with nomad workload identity and nomad autoscaler, and it would seems that the patch for #944 isn't working for me.
Relevant log
Full job HCL
The text was updated successfully, but these errors were encountered: