Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves policy validation in a few ways:
ScalingPolicy.Target
which is amap[string]string
and doesn't actually need validation.strategy
andtarget
.block1->block2
notation from the Nomad docs.validateScalingPolicy
: this is the main function that calls all the others. Testing individual sub-functions failed to capture some cases.-show-validation-error
flag when running tests to seem them:go test -v -run Test_validate ./policy/nomad/ -show-validation-error