plugin: fix bug in ext. strategy plugins suggesting scale to zero. #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way in which stdlib encoding/gob works means a pointer to a types default value will result in the RPC translation becoming nil. This meant external strategy plugins were not able to suggest scaling to zero, as the pointer to zero would be translated to nil which inturn is classed as dry-run. This change removes the use of a pointer for count within strategy action struct. Allowing the use of zero to indicate scaling to zero. Dry run situations use a special -1 count field, to indicate a dry run workflow should be triggered.
cgbaker
approved these changes
May 11, 2020
lgfa29
approved these changes
May 11, 2020
jrasell
added a commit
that referenced
this pull request
May 12, 2020
jrasell
added a commit
that referenced
this pull request
May 12, 2020
changelog: add entry for GH-122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way in which stdlib encoding/gob works means a pointer to a
types default value will result in the RPC translation becoming
nil. This meant external strategy plugins were not able to suggest
scaling to zero, as the pointer to zero would be translated to nil
which inturn is classed as dry-run.
This change removes the use of a pointer for count within strategy
action struct. Allowing the use of zero to indicate scaling to
zero. Dry run situations use a special -1 count field, to indicate
a dry run workflow should be triggered.
closes #83