Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Nomad dependancy to 0.11.2 #128

Merged
merged 2 commits into from
May 18, 2020
Merged

Update Nomad dependancy to 0.11.2 #128

merged 2 commits into from
May 18, 2020

Conversation

jrasell
Copy link
Member

@jrasell jrasell commented May 15, 2020

closes #127

@jrasell jrasell added this to the 0.0.2 milestone May 15, 2020
@jrasell jrasell requested review from lgfa29, jazzyfresh and cgbaker May 15, 2020 09:55
@jrasell jrasell self-assigned this May 15, 2020
cgbaker
cgbaker approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@cgbaker cgbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lgfa29
Copy link
Contributor

lgfa29 commented May 15, 2020 •
edited
Loading

@jrasell just remembered this:
https://github.com/hashicorp/nomad-autoscaler/blob/master/plugins/builtin/target/nomad/plugin/state.go#L97-L98

Should we update from Health to Running? Or maybe fallback from one to the other?

@cgbaker
Copy link
Contributor

cgbaker commented May 15, 2020 via email

@jrasell jrasell merged commit ed7df8a into master May 18, 2020
@jrasell jrasell deleted the gh-127 branch May 18, 2020 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgbaker cgbaker cgbaker approved these changes

@lgfa29 lgfa29 lgfa29 approved these changes

@jazzyfresh jazzyfresh Awaiting requested review from jazzyfresh

Assignees

@jrasell jrasell

Labels
None yet
Projects
None yet
Milestone
0.0.2
Development

Successfully merging this pull request may close these issues.

[enhancement] update Nomad dependancy to latest 0.11.2 release
3 participants
@jrasell @lgfa29 @cgbaker