Re-connect to Nomad if connection is lost #134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the Autoscaler would fail to re-connect to the Nomad server if the connection was dropped.
The main cause for this issue is that the
policyIDsErrCh
was not being consumed, and so the goroutine monitoring the list of policy IDs would block in case of an error.I also uncovered some more subtle ways that the Autoscaler could fail to re-connect properly:
continue
if the Autoscler re-connected to a Nomad cluster where the list of policies were different but the modify index had the same value.To fix these problems I made a few assumptions:
Closes #119