scaleutils: add post scale in task to optionally purge nodes. #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasell
requested review from
cgbaker,
gogococo,
jazzyfresh and
lgfa29
as code owners
When performing cluster scaling and removing nodes from the pool of compute, an operator may optionally wish to have the terminated node removed from the Nomad node list. This can be performed by using the node purge API call and is now included as part of the scaleutils scale in post tasks run. The default behaviour is that the purge is not run. The operator can change this by adding a config option "node_purge" to the target config mapping. The RunPostScaleInTasks func handles checking the target configuration, so that this work does not need to be repeated across all cluster scaling plugins.
jrasell
added a commit
that referenced
this pull request
Sep 8, 2020
jrasell
added a commit
that referenced
this pull request
Sep 8, 2020
changelog: add entry for GH-258
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When performing cluster scaling and removing nodes from the pool
of compute, an operator may optionally wish to have the terminated
node removed from the Nomad node list. This can be performed by
using the node purge API call and is now included as part of the
scaleutils scale in post tasks run.
The default behaviour is that the purge is not run. The operator
can change this by adding a config option "node_purge" to the
target config mapping. The RunPostScaleInTasks func handles
checking the target configuration, so that this work does not need
to be repeated across all cluster scaling plugins.
closes #257