Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

demo: add Azure remote demo #295

Merged
merged 8 commits into from
Nov 13, 2020
Merged

demo: add Azure remote demo #295

merged 8 commits into from
Nov 13, 2020

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Oct 25, 2020

This PR adds cluster scaling demo on Azure using the a VMSS instance. It follows a new folder structure to better organize files per cloud provider. A following PR will adapt the AWS demo to the same structure.

It also updates the provider version constraint in the shared-nomad-jobs module so we can use depends_on between the hashistack_cluster and hashistack_jobs. Without this explicit dependency, Terraform would try to destroy the jobs after the cluster is already gone.

@lgfa29
Copy link
Contributor Author

lgfa29 commented Oct 25, 2020

@jrasell any ideas on how to make Terraform destroy the jobs first? As it is, Terraform will destroy the VMs first and then try to to destroy the jobs, but it will timeout.

I tried the new depends_on for modules, but Terraform was not too happy about it.

@jrasell
Copy link
Member

jrasell commented Oct 26, 2020

@lgfa29 I would expect the fact the jobs module has a requirement on an output of the cluster module to create the correct dependancy chain. Failing that and providing we use TF 0.13, again I would expect it to create the correct dependancy chain between the two modules. Lets look at this online later, hopefully we can figure out a nice solution other than having to do targeted destroys.

@lgfa29 lgfa29 marked this pull request as ready for review November 10, 2020 22:44
Copy link
Contributor

@cgbaker cgbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🏆 🥇

@lgfa29 lgfa29 merged commit f72605f into master Nov 13, 2020
@lgfa29 lgfa29 deleted the add-remote-azure-demo branch November 13, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants