-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
state: reflect key Nomad data within internal store #30
Conversation
PR should have commits squashed before merging! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good stuff 👍. i left some comments, then some issues which i'm not sure about (e.g., whether we stop tracking deleted policies).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On working on #63 I noticed that policies are not being removed when the job is purged (nomad stop --purge
). This should probably be handled in the update function.
This PR has been updated with the new control loop redesign. The main changes include:
|
commits should be squashed when merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small changes before merge, no need for re-review
This PR moves the policy-storage package to use blocking queries on the scaling policy list endpoint. It also adds processing for job scaling state, which is used to identify jobs that are stopped, and in the future will help provide functionality such as cooldowns.
closes #38