Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add HTTP endpoint to reload agent #312

Merged
merged 3 commits into from
Nov 17, 2020
Merged

add HTTP endpoint to reload agent #312

merged 3 commits into from
Nov 17, 2020

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Nov 14, 2020

This PR adds a new HTTP endpoint (/v1/agent/reload) that can be used to trigger the agent to reload, similarly to a SIGHUP signal, which can be useful in situations where file policies are rendered by a sidecar, which can then notify the Autoscaler to reload when policies are modified.

@lgfa29 lgfa29 requested review from jrasell and cgbaker November 14, 2020 00:17
@lgfa29 lgfa29 marked this pull request as ready for review November 17, 2020 01:16
@lgfa29 lgfa29 force-pushed the f-reload-agent-http branch from bf680c4 to b6d36ea Compare November 17, 2020 01:17
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of minor comments as well as a couple of suggestions but nothing drastic and looking wonderful.

agent/http_handler.go Outdated Show resolved Hide resolved
agent/http_handler.go Show resolved Hide resolved
agent/http/server.go Outdated Show resolved Hide resolved
agent/http/agent.go Show resolved Hide resolved
Copy link
Contributor

@cgbaker cgbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice stuff!

@lgfa29 lgfa29 merged commit 0fadb0a into master Nov 17, 2020
@lgfa29 lgfa29 deleted the f-reload-agent-http branch November 17, 2020 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants