Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenStack Senlin Cluster target plugin #370

Closed
wants to merge 11 commits into from

Conversation

dkt26111
Copy link

@dkt26111 dkt26111 commented Feb 5, 2021

This adds a target plugin for OpenStack to scale Nomad cluster clients running as VMs in OpenStack using Senlin clusters.

Senlin is the OpenStack service that allows users to create clusters of VMs for autoscaling purposes. It is similar to AWS ASG.

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 5, 2021

CLA assistant check
All committers have signed the CLA.

@cgbaker
Copy link
Contributor

cgbaker commented Feb 5, 2021

Hi @dkt26111, thank you for the contribution. We're currently in the middle of a discussion about which plugins to include into this repo and which plugins to leave for external plugins. We will get back to you ASAP regarding a decision on this; if you have any opinion on that, we'd be glad to hear your perspective.

@dkt26111
Copy link
Author

dkt26111 commented Feb 5, 2021

I have considered making this as an external plugin so I'm open to that.
Is there a clean way to use scaleutils.ScaleInReq with a custom RemoteProvider in an external plugin? That seems to be the only blocker for me to make this an external plugin.

@cgbaker
Copy link
Contributor

cgbaker commented Feb 8, 2021

Is there a clean way to use scaleutils.ScaleInReq with a custom RemoteProvider in an external plugin? That seems to be the only blocker for me to make this an external plugin.

well-noted, @dkt26111 . we had observed that ourselves and were in the process of addressing it. i'll post an issue to track that and list it here; this will be handled in the next release (0.3.0), along with a change to use gRPC for the plugin system.

@dkt26111
Copy link
Author

dkt26111 commented Feb 8, 2021

Awesome, thanks. Once that is available, I'll move this to an external plugin.

@jrasell
Copy link
Member

jrasell commented Feb 26, 2021

Hi @dkt26111, the refactor is now available and has been released. If you come across any issues, or have any thoughts please let us know. :)

@dkt26111
Copy link
Author

Hi @dkt26111, the refactor is now available and has been released. If you come across any issues, or have any thoughts please let us know. :)

Thanks. I will integrate the changes in the next couple days.

Base automatically changed from master to main March 3, 2021 19:51
@dkt26111
Copy link
Author

I tested my external plugin implementation with the nomad autoscaler 0.3.0 and verified that it works flawlessly. Thank you for your help. I will go ahead and close this PR.

For reference, the OpenStack Senlin target plugin is available here: https://github.com/dkt26111/nomad-senlin-autoscaler

@dkt26111 dkt26111 closed this Mar 21, 2021
@cgbaker
Copy link
Contributor

cgbaker commented Mar 22, 2021

hey @dkt26111 , great stuff! ❤️
we'll get this added to the list of community plugins as soon as we merge hashicorp/nomad#10125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants