scaleutils: refactor to make external plugins possible and easier #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasell
requested review from
gogococo,
jazzyfresh and
lgfa29
as code owners
cgbaker
reviewed
Feb 22, 2021
jrasell
added a commit
that referenced
this pull request
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of the scaleutils package so that external plugins are possible without need to modify the core codebase. The setup of the package is also easier, reducing the strain on plugin developers performing tasks such as config map parsing where possible.
The old functionality has been marked as deprecated and the files moved to use a deprecated prefix. This has been done in the hope to ensure the deprecated code is removed in a timely manner, and not missed easily.
There is a new nodepool package that handles the node pool identification methods. This is wrapped in an interface, allowing us to add additional methods in the future if we desire. This is internal on purpose as I don't see any real reason why this should be the responsibility of plugins, or to even allow that possibility.
All multierrors from scaleutils are now wrapped so their output is formatted in a much easier to read manner. This is currently only used within this package, but would be worth extending to the whole application in the future.
closes #259
closes #377