agent: return req error if prometheus metrics are disabled. #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasell
requested review from
cgbaker,
gogococo,
jazzyfresh and
lgfa29
as code owners
lgfa29
approved these changes
Mar 9, 2021
| @@ -62,12 +66,13 @@ type Server struct { | |||
| } | |||
|
|
|||
| // NewHTTPServer creates a new agent HTTP server. | |||
| func NewHTTPServer(debug bool, cfg *config.HTTP, log hclog.Logger, agent AgentHTTP) (*Server, error) { | |||
| func NewHTTPServer(debug, prom bool, cfg *config.HTTP, log hclog.Logger, agent AgentHTTP) (*Server, error) { | |||
There was a problem hiding this comment.
I think we're getting to the point where the input to NewHTTPServer would be better as a struct 😄
There was a problem hiding this comment.
Agreed and this did cross my mind that we just pass the whole config object. I'll follow this up in a new PR to refactor the func signature.
There was a problem hiding this comment.
I think passing the whole config would be too much, just the current params in a HTTPServerConfig struct should be enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has disabled Prometheus metrics and a request is
sent to the metrics endpoint requesting Prometheus formatted
metrics, then the request should fail.
The returned response code copies that of Consul and Nomad,
to provide a consistent user experience.
closes #398