-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pass-through strategy plugin #433
Conversation
TODO: add documentation to nomadproject.io website in nomad repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Early review and it's looking good! Just a few places with the wrong plugin name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me!
why pass-thru
and not pass-through
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a commit to guard against empty metric results. It shouldn't really happen inside a plugin (the worker won't call the plugin without metrics), but just in case.
This check is also present in the target-value
plugin, but it's wrong 😬
This feature would introduce a new strategy plugin for simple pass-through scaling action. That is, whatever the value returned by the APM, this strategy will scale to that value exactly.
This strategy would be incorporated into a scaling policy like so: