Fix empty node selector strategy
#450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgfa29
requested review from
cgbaker,
gogococo,
jazzyfresh and
jrasell
as code owners
lgfa29
force-pushed
the
fix-empty-node-selector
branch
from
8d54292 to
4f4f728
Compare
jrasell
approved these changes
Apr 6, 2021
lgfa29
added a commit
that referenced
this pull request
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
emptynode selector strategy had a wrong check that ended causing the opposite of the expected result. It would also fail to scale-in if system jobs were deployed.This PR fixes the check and also ignores system job allocs when using the
emptystrategy. It also adds some basic tests using test-fixtures retrieved from a live Nomad cluster.