scaleutils: add datacenter nodepool implementation #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasell
added a commit
that referenced
this pull request
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #459
When understanding the nodes which form a scalable pool of resource, the Nomad Autoscaler uses the nodepool interface which provides functionality to understand node grouping. This change adds a new implementation,
datacenter, which allows nodes to be group according to their datacenter configuration option.The cluster policy validation has been updated to account for this change. Particuary the
node_classanddatacenteroptions are mutually exclusive. The new validation functions use thehelper/errorpkg to create better formatted errors. Work to update the entire error chain will be conducted in a follow up PR.The Nomad project site will need updating to document the new config option. It may also prove valuable to add a demo, or at least commented out examples of using
datacenterrather thannode_class.