scaleutils: fix least busy selector on clusters older than v1.0.0 #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds additional API calls when performing the least busy node selector as a best effort to work on cluster that running Nomad versions before v1.0.0. v1.0.0 including API functionality which allows node resources to be include in the stub list node object which is used when performing least busy calculations. In version priror to this, the information is only available within the node info object.
|
@jrasell if there is a version of this built, we're happy to test it out to see if it gets rid of the reported panics :) |
lgfa29
approved these changes
Jul 6, 2021
lgfa29
reviewed
Jul 7, 2021
Co-authored-by: Luiz Aoqui <luiz@hashicorp.com>
@josegonzalez This fix will be available tomorrow when the nightly release runs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds additional API calls when performing the least busy node
selector as a best effort to work on cluster that running Nomad
versions before v1.0.0.
v1.0.0 including API functionality which allows node resources to
be include in the stub list node object which is used when
performing least busy calculations. In version prior to this, the
information is only available within the node info object.
closes #506