Allow datacenter and node class filtering #535
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial implementation for the node filtering would only take either node class or datacenter as the filter input. But as explained in #531, there are valid use cases where defining both is required in order to properly match Nomad clients with cloud instances.
This PR creates a new
ClusterNodePoolIdentifier
calledcombinedClusterPoolIdentifier
that can be used to merge other identifiers, applying a simpleand
oror
logic.When both
node_class
anddatacenter
are present in a scaling policy, the Autoscaler will use this combined identifier to merge the existingNewNodeDatacenterPoolIdentifier
andNewNodeDatacenterPoolIdentifier
logic with theand
operator.In the future we may add an option to use the
or
operator, but it's not clear to me if there is any real benefit since it would increase the node pool instead of reducing it. Regardless, the capability is there if needed.Closes #531