Dispense fixed-value, pass-through, and threshold strategy plugins by default #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgfa29
requested review from
gogococo,
jazzyfresh and
jrasell
as code owners
lgfa29
added a commit
that referenced
this pull request
Nov 12, 2021
lgfa29
force-pushed
the
dispense-default-plugins
branch
from
2039688 to
304828d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When these new strategy plugins were added, we forgot to update the agent to auto-dispense them.
I wonder if we should just auto-dispense all builtin plugins and add a new flag to allow disabling specific ones if needed, but some of them require additional configuration (like
aws-asg,prometheusetc), so the user would have to declare them anyway.It would be cool if we could detect plugins that don't require additional config and auto-dispense them, but I couldn't think of a way to easily check this.
Closes #532