Downgrade error message from app scaling due to active deployment #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgfa29
requested review from
gogococo,
jazzyfresh and
jrasell
as code owners
Co-authored-by: James Rasell <jrasell@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Autoscaler is fairly likely to encounter active deployments during policy evaluations, either due to previous scaling actions that are taking longer than the policy
evaluation_internvalandcooldown, or due to manual job updates by operators.This situation is usually not detrimental to the overall scaling progress since the deployment is expected to eventually complete and future policy evaluations will correct the group
countif necessary.This PR reduces the log level for when this happen from an
ERRORto justINFO.It also introduces a new concept of
TargetScalingNoOpErrorwhich is a special error type that target plugins can use in situations like this, where the scaling action request didn't actually complete, but that's not really a problem.Closes #515