func: add metadata for drained nodes #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasell
reviewed
May 17, 2023
Co-authored-by: James Rasell <jrasell@users.noreply.github.com>
jrasell
approved these changes
May 23, 2023
sdk/helper/scaleutils/node_drain.go
Outdated
| DrainSpec: spec, | ||
| MarkEligible: false, | ||
| Meta: map[string]string{ | ||
| NODE_DRAINED_META_KEY: NODE_DRAINED_META_VALUE, |
There was a problem hiding this comment.
Suggested change
| NODE_DRAINED_META_KEY: NODE_DRAINED_META_VALUE, | |
| nodeDrainedMetaKey: nodeDrainedMetaValue, |
Co-authored-by: James Rasell <jrasell@users.noreply.github.com>
Co-authored-by: James Rasell <jrasell@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue found here
The nomad autoscaler should be able to set up specific metadata for nodes that are being drain, in order to pick up where it left off in case of a failure. This PR introduces the change. It also adds an interface to make decoupling from the nomad cluster easier for testing on this feature and maybe some more in the future.