Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

policy: validate missing strategy #813

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Dec 22, 2023

Return an error if a check is missing a strategy value to prevent panics.

Closes #611

lgfa29 added a commit that referenced this pull request Dec 22, 2023
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
Return an error if a `check` is missing a `strategy` value to prevent
panics.
@lgfa29 lgfa29 force-pushed the b-fix-panic-on-missing-strategy branch from 7c9e09e to 3c88bbc Compare January 2, 2024 18:52
lgfa29 added a commit that referenced this pull request Jan 2, 2024
@lgfa29 lgfa29 force-pushed the b-fix-panic-on-missing-strategy branch from 3c88bbc to fbb8a97 Compare January 2, 2024 18:54
@lgfa29 lgfa29 merged commit 324fbc6 into main Jan 2, 2024
24 checks passed
@lgfa29 lgfa29 deleted the b-fix-panic-on-missing-strategy branch January 2, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autoscaler crashes with SIGSEGV if strategy is missing from check in policy
2 participants