Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: add policy_id and target_name labels to scale invoke #814

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Dec 22, 2023

Add policy_id and target_name labels to scale.invoke.success_count and scale.invoke.error_count metrics to help operators track policies that may be failing.

Closes #593

lgfa29 added a commit that referenced this pull request Dec 22, 2023
@lgfa29 lgfa29 force-pushed the f-metrics-add-policy-id-to-invoke branch from 36d7bc6 to f0c6d22 Compare December 22, 2023 01:51
lgfa29 added a commit that referenced this pull request Dec 22, 2023
@lgfa29 lgfa29 changed the title metrics: add policy_id label to scale invoke metrics: add policy_id and target_name labels to scale invoke Dec 22, 2023
Copy link
Member

@jrasell jrasell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lgfa29 added 2 commits January 2, 2024 13:43
Add `policy_id` and `target_name` labels to
`scale.invoke.success_count` and `scale.invoke.error_count` metrics to
help operators track policies that may be failing.
@lgfa29 lgfa29 force-pushed the f-metrics-add-policy-id-to-invoke branch from f0c6d22 to 87468bd Compare January 2, 2024 18:44
@lgfa29 lgfa29 merged commit d79f77b into main Jan 2, 2024
24 checks passed
@lgfa29 lgfa29 deleted the f-metrics-add-policy-id-to-invoke branch January 2, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Telemetry] policy_id and target_name on all scaling metrics
2 participants